diagnostics: dedup ParseSizeError handling

[sylvestre]

Four cleanup commits after the recent ariadne/caret diagnostic work:

1. uucore: add ParseSizeError::format_option_error, drop per-util copies — sort, du and od each had an identical 12-line format_error_message function. Moved to a method on ParseSizeError in uucore, with shared FTL keys.

2. sort, du, od: inline format_error_message, call format_option_error directly — removes the now-trivial one-liner wrapper and calls the method at each site.

3. dd, install, stat: remove redundant UError::code() = 1 — UError::code() already defaults to 1; these three overrides were dead code.

4. od: drop local size_error helper, inline render_size_value directly — the local size_error function was a thin wrapper around render_size_value + quiet_if_reported, already available in uucore.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codspeed-hq]

Merging this PR will degrade performance by 1.11%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 5 regressed benchmarks
✅ 350 untouched benchmarks
⏩ 50 skipped benchmarks¹

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
❌	Simulation	seq_formatted	161.8 ms	180.1 ms	-10.19%
❌	Simulation	numfmt_stream_to_si	292.1 ms	307.6 ms	-5.06%
❌	Simulation	wc_bytes_synthetic[500]	183.4 µs	190 µs	-3.46%
❌	Simulation	numfmt_stream_to_si_precision	348.8 ms	361 ms	-3.38%
❌	Memory	tee_stdin_file[10000000]	71.3 KB	73.7 KB	-3.2%
⚡	Simulation	mv_force_overwrite	233 ms	202.3 ms	+15.18%
⚡	Simulation	cksum_crc	42 ms	40.3 ms	+4.3%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing sylvestre:diag-dedup (b084129) with main (df30282)²}

Footnotes

1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (5188b6f) during the generation of this report, so df30282 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!
Congrats! The gnu test tests/seq/seq-epipe is now passing!
Congrats! The gnu test tests/tail/tail-n0f is now passing!

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.