fix(healthcheck): adopt upstream ArgoCD NNCP health check - #31
Merged
aharivel merged 1 commit intoAug 18, 2026
Merged
Conversation
Replace custom NNCP healthcheck with the ArgoCD v3.4+ built-in version, adding Ignored->Suspended mapping and condition.reason in messages. Jira: OSPRH-33119 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-by: oliashish3@gmail.com
cjeanner
approved these changes
Aug 18, 2026
aharivel
approved these changes
Aug 18, 2026
aharivel
left a comment
aharivel
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, clean adoption of upstream Argocd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace custom NNCP healthcheck with the ArgoCD v3.4+ built-in version, adding Ignored->Suspended mapping and condition.reason in messages.
Jira: OSPRH-33119
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Signed-by: oliashish3@gmail.com