Repository navigation
Link against libstdc++ - #23
Merged
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
kvmandtinykvmVMOD targets declare only C source files, solibtoollinks their shared objects using the C compiler. However, both targets also include the C++libkvm.aandlibtinykvm.astatic archives.Without an explicit C++ runtime dependency, loading either VMOD can fail when
libstdc++has not already been loaded into the Varnish process:I found this in EL10, where jemalloc does not pull in
libstdc++. Debian and Ubuntu hid the missing dependency becauselibstdc++is already present from their jemalloc packaging.Adding
-lstdc++after the static archives gives both shared objects the dependency they require, independently of the host distribution's transitive dependencies.