fix(slack): return replyable thread ID from channel posts#720
Open
akkadaska wants to merge 1 commit into
Open
Conversation
Contributor
|
@akkadaska is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixes #719
updates Slack channel posts to return a replyable thread ID rooted at the newly posted top-level message
postChannelMessagestill omitsthread_tsfor the initial channel post, then uses Slack's returned messagetsto constructslack:<channel>:<ts>for theSentMessagethis allows
chat.thread(sent.threadId).post(...)to reply to a message returned bychannel.post(...)instead of creating another top-level channel messagefile-only uploads without a Slack message
tskeep their existing channel-scoped thread IDtest plan
postChannelMessagereturnsslack:C123:<message ts>@chat-adapter/slacktest suitepnpm validatechecklist