Enables sixel support for windows by using node-pty 1.1.0's copy of ConPTY instead of Window's older ConPTY - #8210
Open
blindmikey wants to merge 1 commit into
Open
Enables sixel support for windows by using node-pty 1.1.0's copy of ConPTY instead of Window's older ConPTY#8210blindmikey wants to merge 1 commit into
blindmikey wants to merge 1 commit into
Conversation
…minal Bump node-pty 1.0.0 -> 1.1.0 and pass `useConptyDll: true`, loading the ConPTY that ships with node-pty (1.23.251008001) instead of the one built into Windows. Older inbox ConPTY versions answer DA1 themselves without the Sixel attribute and filter DCS out of the output stream, so `imageSupport` never receives any image data on those builds. Also run node-pty's post-install.js after rebuild-node-pty: node-gyp clears build/, and pnpm 10 does not run node-pty's own lifecycle scripts (onlyBuiltDependencies), so conpty.dll goes missing next to conpty.node and loading it fails at runtime. Adds a `useConptyDll` config option (default true) to opt back out. before: ESC[?61;6;7;21;22;23;24;28;32;42c (conhost answering, no 4) after: ESC[?62;4;9;22c (xterm-addon-image answering)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8209
Bumps node-pty 1.0.0 -> 1.1.0 and passes
useConptyDll: true, loading the ConPTY that ships with node-pty (1.23.251008001) instead of the one built into Windows. Older inbox ConPTY versions answer DA1 themselves without the Sixel attribute and filter DCS out of the output stream, soimageSupportnever receives any image data on those builds.Also run node-pty's post-install.js after rebuild-node-pty: node-gyp clears build/, and pnpm 10 does not run node-pty's own lifecycle scripts (onlyBuiltDependencies), so conpty.dll goes missing next to conpty.node and loading it fails at runtime.
Adds a
useConptyDllconfig option (default true) to opt back out.before: ESC[?61;6;7;21;22;23;24;28;32;42c (conhost answering, no 4)
after: ESC[?62;4;9;22c (xterm-addon-image answering)
This should be good to merge after review. Thanks for building such an awesome terminal! Happy to contribute in a small way.