Skip to content

Feature/arc 3904 video player - #150

Merged
reunefe merged 22 commits into
masterfrom
feature/ARC-3904_video-player
Sep 8, 2026
Merged

Feature/arc 3904 video player#150
reunefe merged 22 commits into
masterfrom
feature/ARC-3904_video-player

Conversation

@reunefe

@reunefe reunefe commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@reunefe
reunefe requested a review from bertyhell September 4, 2026 06:59
Comment thread src/components/AudioWaveFormDisplay/AudioWaveFormDisplay.helpers.ts Outdated
Comment thread src/components/AudioWaveFormDisplay/AudioWaveFormDisplay.helpers.ts Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.tsx Outdated
Comment thread src/components/FlowPlayer/Controls/Controls.consts.ts Outdated
Comment thread src/components/FlowPlayer/FlowPlayer.types.ts
@reunefe
reunefe requested a review from bertyhell September 8, 2026 08:28

@RobbeBierebeeck RobbeBierebeeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paar opmerkingen, vooral rond de FA en toegankelijkheid. Los daarvan: mooi opgezet, de comments bij de Flowplayer-workarounds helpen echt.

Comment thread src/components/FlowPlayer/Controls/VolumeControl.tsx
Comment thread src/components/FlowPlayer/Controls/ProgressBar.tsx
Comment thread src/components/FlowPlayer/Controls/ProgressBar.tsx
Comment thread src/components/FlowPlayer/Controls/ControlBar.scss
Comment thread src/components/FlowPlayer/Controls/ControlFlyout.tsx Outdated
Comment thread src/components/FlowPlayer/Controls/SpeedControl.tsx Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.tsx Outdated
Comment thread src/components/FlowPlayer/Controls/ControlBar.tsx
Comment thread src/utils/formatters/duration.ts
Comment thread src/components/AudioWaveFormDisplay/AudioWaveFormDisplay.tsx
Comment thread src/components/FlowPlayer/Controls/useKeyboardShortcuts.ts
@reunefe
reunefe merged commit 2aa9834 into master Sep 8, 2026
@reunefe
reunefe deleted the feature/ARC-3904_video-player branch September 8, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants