Repository navigation
Conversation
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1616 +/- ##
==========================================
+ Coverage 84.00% 84.03% +0.02%
==========================================
Files 44 44
Lines 11713 11720 +7
Branches 2625 2629 +4
==========================================
+ Hits 9840 9849 +9
+ Misses 1873 1871 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…cteristics Previously, all HLS SUBTITLES media group renditions were assigned the 'subtitles' text track kind by default. According to the W3C and WHATWG HTML standards, tracks that transcribe dialogue or describe music and sounds are called **captions**. They're intended to help people who are deaf or hard of hearing. The HLS RFC 8216 standard allows `CHARACTERISTICS` to contain several comma-separated values, such as `public.easy-to-read`. The kind is now determined by checking each value separately. Specifications references: - HLS RFC 8216 Section 4.3.4.1 (ref Characteristics): https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.4.1 ```text A SUBTITLES Rendition MAY include the following characteristics: "public.accessibility.transcribes-spoken-dialog", "public.accessibility.describes-music-and-sound", and "public.easy-to-read" (which indicates that the subtitles have been edited for ease of reading). ``` - HLS RFC 8216 Section 8.9: https://datatracker.ietf.org/doc/html/rfc8216#section-8.9 ```text CHARACTERISTICS Attribute Containing Multiple Characteristics Certain characteristics are valid in combination, as in: CHARACTERISTICS= "public.accessibility.transcribes-spoken-dialog,public.easy-to-read" ``` - WHATWG HTML / W3C HTML5 Track Kind 'captions': https://html.spec.whatwg.org/multipage/media.html#attr-track-kind-keyword-captions https://www.w3.org/TR/2011/WD-html5-20110113/video.html#the-track-element ```text captions Closed captions provide transcription or translation of the dialog, sound effects, relevant musical cues, and other relevant audio information, such as the cue's source (e.g., character, environment). They are suitable for when sound is unavailable or not clearly audible (e.g., because it is muted, drowned-out by ambient noise, or because the user is deaf). ``` - add a private function named `textTrackKind_` that will determine the correct kind - add test cases
amtins
force-pushed
the
fix/hls-characteristics
branch
from
October 17, 2026 16:59
af45ac6 to
7ec06b0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, all HLS SUBTITLES media group renditions were assigned the
'subtitles' text track kind by default.
According to the W3C and WHATWG HTML standards, tracks that transcribe dialogue
or describe music and sounds are called captions. They're intended to help
people who are deaf or hard of hearing.
The HLS RFC 8216 standard allows
CHARACTERISTICSto contain severalcomma-separated values, such as
public.easy-to-read. The kind is nowdetermined by checking each value separately.
Specifications references:
HLS RFC 8216 Section 4.3.4.1 (ref Characteristics):
https://datatracker.ietf.org/doc/html/rfc8216#section-4.3.4.1
HLS RFC 8216 Section 8.9:
https://datatracker.ietf.org/doc/html/rfc8216#section-8.9
WHATWG HTML / W3C HTML5 Track Kind 'captions':
https://html.spec.whatwg.org/multipage/media.html#attr-track-kind-keyword-captions
https://www.w3.org/TR/2011/WD-html5-20110113/video.html#the-track-element
Specific Changes proposed
textTrackKind_that will determine the correct kindRequirements Checklist