Repository navigation
Qualify local frames and add GeographicLib benchmark baselines - #302
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9b0c4c79a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
326b418 to
8fde2cd
Compare
[Medium impact] The reviewed changes appear safe to merge; both previous findings are addressed. SummaryThis PR adds shared local-frame qualification and informational GeographicLib benchmark baselines.
This review checked the code and stored results; it did not rerun the tests.
|
Coverage Report for CI Build 40140281525Coverage decreased (-0.03%) to 94.226%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Problem and behavior
C8 had no shared independent qualification matrix, and the G7 API/performance roadmap lacked reproducible equal-accuracy baselines. Qualification exposed three boundary failures: rigid transforms could overflow intermediate arithmetic despite finite outputs; radial tangent lifts could reject representable points on tiny ellipsoids; and spherical normal lifts could accept a one-ulp miss or lose accuracy near grazing contact.
This PR fixes those cases, adds 560 shared qualification rows, and establishes informational G7/C8 benchmark baselines without adding dependencies. The bounded qualification domain and intentional native convention differences are documented; this does not claim arbitrary finite-input certification or universal GeographicLib parity.
Evidence
Validation
Full Node suite: 13,202 passed, 124 skipped. Lint, build, attribution/source-header checks, strict ESM/CJS consumer types, C8 package graphs/budgets and existing geodesic/seam/projection/allocation boundaries passed locally. Shared 560-row qualification passed Node, Chromium and WebKit locally and Firefox in CI. Review fixes cover pinned-baseline fetching in shallow CI, conservative historical package metadata, strict ESM/CommonJS consumer types, and validation of every actual optional-native answer before timing. A deliberately wrong finite native executable is rejected before measurement/report creation. The refreshed benchmark artifact includes all 72 actual-native qualification results. Latest-head CI is the final gate.