Repository navigation
Expose GeoArrow dimension inference utilities - #303
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryExposes shared helpers for combining GeoArrow dimensions and inferring dimensions from tagged geometry coordinates.
No actionable issues were found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "Expose GeoArrow dimension inference util..." · Reviewed by Greptile |
Coverage Report for CI Build 40140806399Coverage remained the same at 94.252%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
Goals
Provide Arrow-independent GeoArrow dimension helpers in math.gl so loaders.gl and other adapters can share the same XYZ/XYM semantics when constructing geometry columns.
Changes
mergeGeoArrowDimensionsto combine elevation and measure dimensions without conflating them.inferGeoArrowGeometryDimensionfor tagged geometry values, including nested coordinate arrays and collections. Three ordinates default to XYZ; explicit XYM metadata remains authoritative.Verification
yarn install --mode=skip-buildyarn lint fixyarn buildyarn test-node(215 files; 12,697 passed)yarn test-headless(215 files; 12,694 passed)yarn check:geoarrow-boundary