Skip to content

Expose GeoArrow dimension inference utilities - #303

Merged
ibgreen merged 1 commit into
masterfrom
codex/geoarrow-dimension-utils
Oct 25, 2026
Merged

ibgreen merged 1 commit into
masterfrom
codex/geoarrow-dimension-utils

Conversation

@ibgreen

@ibgreen ibgreen commented Oct 24, 2026

Copy link
Copy Markdown
Contributor

Goals

Provide Arrow-independent GeoArrow dimension helpers in math.gl so loaders.gl and other adapters can share the same XYZ/XYM semantics when constructing geometry columns.

Changes

  • Export mergeGeoArrowDimensions to combine elevation and measure dimensions without conflating them.
  • Export inferGeoArrowGeometryDimension for tagged geometry values, including nested coordinate arrays and collections. Three ordinates default to XYZ; explicit XYM metadata remains authoritative.
  • Reuse the shared merge helper inside math.gl's WKB decoder, removing its duplicate private implementation.
  • Document the helpers and cover empty, nested, mixed, 2D, 3D, and 4D geometry cases.

Verification

  • yarn install --mode=skip-build
  • yarn lint fix
  • yarn build
  • yarn test-node (215 files; 12,697 passed)
  • yarn test-headless (215 files; 12,694 passed)
  • yarn check:geoarrow-boundary

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-24T22:58:44.944193Z
We couldn’t complete this review. Comment @codex review to try again.
31e9e52 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Exposes shared helpers for combining GeoArrow dimensions and inferring dimensions from tagged geometry coordinates.

  • GeoArrow callers can infer and combine geometry dimensions.

No actionable issues were found. Tests were inspected but not run during this review.

Reviews (1) · Last reviewed commit: "Expose GeoArrow dimension inference util..." · Reviewed by Greptile

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 40140806399

Coverage remained the same at 94.252%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 16 of 16 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 25839
Covered Lines: 24922
Line Coverage: 96.45%
Relevant Branches: 15953
Covered Branches: 14468
Branch Coverage: 90.69%
Branches in Coverage %: Yes
Coverage Strength: 37443.68 hits per line

💛 - Coveralls

@ibgreen
ibgreen merged commit 89a3778 into master Oct 25, 2026
12 checks passed
@ibgreen
ibgreen deleted the codex/geoarrow-dimension-utils branch October 25, 2026 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants