Preserve FIFO order when pausing HelperCustomQueue - #70
Open
Niketion wants to merge 1 commit into
Open
Conversation
Niketion
marked this pull request as ready for review
August 6, 2026 10:33
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30e89e985d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HelperCustomQueue<T>.Root cause
The consumer previously dequeued an item before checking whether a pause had been requested. When paused, it wrote that item back to the same channel.
Re-enqueueing moved the item behind entries already in the channel, so an ordered sequence such as
A, B, Ccould be processed asA, C, B.This is particularly problematic for ordered market-data streams and exchange sequence handling.
Behavior
The consumer now checks the pause state before claiming the next item. An item already claimed because of a concurrent pause is processed once, and the following loop iteration observes the pause.
No shutdown, disposal, public API, monitoring, or connector behavior is changed.
Tests
PauseDuringBatch_PreservesFifoOrderPauseBeforeEnqueue_DoesNotProcessUntilResumeValidation completed:
VisualHFT.Commonsbuild: passed