Repository navigation
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin authors who copy the Kit guides can subscribe to lifecycle events that never fire, register a JSON dock that fails to render, or construct a remote URL that the parser does not recognize.
Correct the guides, skill references and JSON renderer comments to match the current API. Clarify that host lifecycle events run in the Node process.
Evidence
After: All documented event families received notifications. Corrected event and JSON examples passed type checking. The real JSON renderer displayed the corrected view in a browser fixture with controlled shared state. Both fragment and query descriptors parsed with the corrected key.
pnpm lint,pnpm test --run(400 passed, 2 skipped),pnpm typecheck,pnpm buildand the documentation site build passed.Merge Danger
Door: two-way
Blast Radius: documentation
The changes cover guides, skill references and source comments. Runtime behavior is unchanged.