New package: ClassiCube-1.3.8#60669
Open
r0man1an wants to merge 1 commit into
Open
Conversation
ahesford
requested changes
Jun 22, 2026
| sed -i '/SIGCHLD/d' src/Platform_Posix.c | ||
| } | ||
|
|
||
| do_build() { |
Member
There was a problem hiding this comment.
Why are you not using the function provided by the build style?
| distfiles="https://github.com/ClassiCube/ClassiCube/archive/${version}.tar.gz" | ||
| checksum=35293acf1e63baeca832dec2512283f2975c79ddf80cc855a12c10464723a6c4 | ||
|
|
||
| pre_build() { |
Member
There was a problem hiding this comment.
Why are these patches being applied?
If they are legitimate, they are done incorrectly:
- Static patches like this should be contained in an actual patch file. Invoking sed hides context and can obscure incorrect or obsolete changes.
- When dynamic changes would be necessary, use
vsedinstead of rawsedto help catch obsolete changes. - Dynamic changes belong in
post_patch, notpre_build.
| vbin ClassiCube 755 usr/bin ClassiCube-bin | ||
| vlicense license.txt | ||
| vinstall misc/CCicon.png 644 usr/share/pixmaps classicube.png | ||
| vbin ${FILESDIR}/ClassiCube.sh 755 usr/bin ClassiCube |
Member
There was a problem hiding this comment.
We don't vendor launch scripts like this. Remove the script.
| vbin ${FILESDIR}/ClassiCube.sh 755 usr/bin ClassiCube | ||
|
|
||
| vmkdir usr/share/applications | ||
| cat > "${DESTDIR}/usr/share/applications/classicube.desktop" <<-EOF |
Member
There was a problem hiding this comment.
We don't vendor desktop entries. Remove this block.
Contributor
Author
There was a problem hiding this comment.
Thank you for your detailed feedback!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
New package
Local build testing