Skip to content

fix: harden mipmap creation failure handling - #87

Open
luojiyin1987 wants to merge 4 commits into
voidtools:masterfrom
luojiyin1987:fix/mipmap-failure-handling
Open

fix: harden mipmap creation failure handling#87
luojiyin1987 wants to merge 4 commits into
voidtools:masterfrom
luojiyin1987:fix/mipmap-failure-handling

Conversation

@luojiyin1987

@luojiyin1987 luojiyin1987 commented Sep 9, 2026

Copy link
Copy Markdown

Summary

  • Create scaled GDI bitmaps in _viv_create_mipmap_bitmap.
  • Keep GDI resource handling out of _viv_get_mipmap.
  • Publish each mipmap only after bitmap creation succeeds.
  • Free partial resources and return the last valid mipmap after failure.
  • Capture each GDI error before cleanup changes the thread error state.

Validation

  • git diff --check
  • Reviewed each GDI failure path for cleanup and fallback behavior.
  • A full build needs the Windows MSVC environment.

@luojiyin1987
luojiyin1987 marked this pull request as draft September 9, 2026 04:07
@luojiyin1987
luojiyin1987 marked this pull request as ready for review September 9, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant