Repository navigation
perf(migrate): avoid repeated lockfile parsing during preflight - #3212
Merged
fengmk2 merged 1 commit intoOct 23, 2026
Merged
Conversation
Reuse parsed lockfiles within each Vitest migration plan across pnpm, npm, Yarn and Bun. Keep version resolution package-specific and create fresh readers for subsequent plans. Cover parsing reuse, mixed runner versions, changed inputs, malformed lockfiles and npm shrinkwrap precedence.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
October 23, 2026 08:51
jong-kyung
added
test: e2e
fengmk2
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speed up Vitest migration preflight in workspaces by reusing parsed lockfiles instead of reparsing them for every package.
This covers pnpm, npm, npm shrinkwrap, Yarn Modern, Yarn Classic, and Bun. Each migration plan gets a fresh cache, while package-specific version resolution and apply-time input validation remain unchanged.