Repository navigation
fix(env): show warnings in doctor summary - #3222
liangmiQwQ wants to merge 2 commits into
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
huh |
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
When
vp env doctorfinds only warnings, the last line still says✓ All checks passed, even though the output above it shows⚠rows.This PR makes the summary depend on what doctor found:
✗ Some issues found., exit code 1 (unchanged).⚠ Some warnings found., exit code 0.✓ All checks passed, exit code 0 (unchanged).Warnings still exit with 0, because they describe setups that still work (#3215).
Every warning row now goes through a
print_warninghelper, which records that a warning was shown. Warnings come from many checks that otherwise return nothing, so recording them as they print avoids changing every check's return type.🤖 Generated with Claude Code