Skip to content

chore(tls): drop the embedded trust store from the lockfile - #872

Draft
wan9chi wants to merge 2 commits into
mainfrom
cursor/ban-embedded-trust-store-b046
Draft

wan9chi wants to merge 2 commits into
mainfrom
cursor/ban-embedded-trust-store-b046

Conversation

@wan9chi

@wan9chi wan9chi commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Motivation

vp verifies remote-cache HTTPS certificates with the operating system's trust store through rustls-platform-verifier. Cargo still recorded webpki-root-certs, Mozilla's compiled-in roots, because that crate depends on it for wasm32. No shipping build compiles that edge, but the lockfile lists every target-specific dependency, so the embedded store stayed in the resolve.

rustls-platform-verifier 0.7.0 is now vendored, with that wasm32 dependency and its dev-dependency removed. Cargo.lock no longer contains webpki-root-certs or webpki-roots. deny.toml bans both crates, and the format job runs cargo deny check bans, so a later dependency cannot bring an embedded trust store back into the lockfile.

Open in Web Open in Cursor 

HTTPS verification uses the operating system's trust store. Ban
webpki-roots and webpki-root-certs for the platforms CI builds, and
run that check in CI so a compiled-in Mozilla store cannot be linked
into those builds later.

Co-authored-by: Grok 4.7 <noreply@x.ai>
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +0.45%  [ -6.83% ..  +7.25%]  overhead   +58.75%
dynamic/access             change  -1.83%  [-17.62% .. +10.34%]  overhead   +17.82%
dynamic/access-relative    change  +0.44%  [ -4.83% ..  +6.61%]  overhead   +69.93%
dynamic/access-contended   change  -3.41%  [-20.62% .. +15.92%]  overhead    +4.47%
static/launch              change  +0.60%  [ -5.62% ..  +7.59%]  overhead  +140.38%
static/access              change  +1.58%  [ -7.57% .. +14.50%]  overhead +3192.16%
static/access-relative     change  +1.02%  [ -2.74% ..  +5.76%]  overhead +3580.35%
static/access-contended    change  -0.18%  [ -3.34% ..  +5.45%]  overhead +4103.17%

macos

dynamic/launch             change  -0.25%  [ -4.20% ..  +4.62%]  overhead  +265.22%
dynamic/access             change  -0.68%  [-50.78% .. +83.84%]  overhead    +1.13%
dynamic/access-relative    change  -2.20%  [-42.50% .. +18.71%]  overhead  +222.73%
dynamic/access-contended   change  +2.47%  [ -8.46% .. +29.66%]  overhead    +9.29%

windows

dynamic/launch             change  -0.75%  [ -9.95% .. +14.28%]  overhead   +25.09%
dynamic/access             change  +0.34%  [ -6.11% .. +31.56%]  overhead    +3.19%
dynamic/access-relative    change  -0.17%  [-15.07% ..  +7.90%]  overhead    +1.88%
dynamic/access-contended   change  -2.25%  [-15.67% .. +10.60%]  overhead    +4.54%

Cargo.lock records rustls-platform-verifier's wasm32 dependency on
webpki-root-certs even though no build enables that edge. Vendor
0.7.0 and remove that dependency so the embedded Mozilla roots are
not locked.

Co-authored-by: Grok 4.7 <noreply@x.ai>
@cursor cursor Bot changed the title chore(tls): ban embedded trust stores chore(tls): drop the embedded trust store from the lockfile Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants