Repository navigation
Conversation
HTTPS verification uses the operating system's trust store. Ban webpki-roots and webpki-root-certs for the platforms CI builds, and run that check in CI so a compiled-in Mozilla store cannot be linked into those builds later. Co-authored-by: Grok 4.7 <noreply@x.ai>
fspy benchmarklinuxmacoswindows |
Cargo.lock records rustls-platform-verifier's wasm32 dependency on webpki-root-certs even though no build enables that edge. Vendor 0.7.0 and remove that dependency so the embedded Mozilla roots are not locked. Co-authored-by: Grok 4.7 <noreply@x.ai>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
vpverifies remote-cache HTTPS certificates with the operating system's trust store throughrustls-platform-verifier. Cargo still recordedwebpki-root-certs, Mozilla's compiled-in roots, because that crate depends on it for wasm32. No shipping build compiles that edge, but the lockfile lists every target-specific dependency, so the embedded store stayed in the resolve.rustls-platform-verifier0.7.0 is now vendored, with that wasm32 dependency and its dev-dependency removed.Cargo.lockno longer containswebpki-root-certsorwebpki-roots.deny.tomlbans both crates, and the format job runscargo deny check bans, so a later dependency cannot bring an embedded trust store back into the lockfile.