Repository navigation
Conversation
yangshun
commented
Oct 25, 2026
Contributor
Author
There was a problem hiding this comment.
This PR ships the SVG files with the core void package. This means every Void user will have these SVGs in their node_modules. Not ideal IMO.
I'm not a fan of this, but since the starter code is already implemented within void/src/cli/template.ts and since the logos are just a few KB and doesn't enter a built bundle, it's not that terrible.
My preference would be to shift the starter code and assets into create-void, but then void init will have to call create-vite, creating a circular dep. I'm not sure why void init needs to exist when there's create-void. Maybe it can be removed?
yangshun
marked this pull request as ready for review
October 25, 2026 12:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the plain
void initwelcome pages with a shared Vite-style layout for React, Vue, Svelte, and Solid, using Void colors, system fonts, and automatic light/dark mode.Preserve the original Pages-mode guidance and the database starters' message list, form, API example, and seed instructions. Bundle a small stack SVG and a theme-aware Void logo with
void, with Vite attribution embedded in the icon sprite.Keep the shared starter styles in a CSS source file and inline the raw CSS into the CLI bundle, with matching type declarations and build/test configuration.
Caution
This ships the SVG files with the core
voidpackage. I'm not a fan of this but the starter code is already implemented withinvoidand since the files are just a few KB + not bundled into the build, it's not terrible.My preference would be to shift the starter code and assets into
create-void, but thenvoid initwill have to callcreate-vite, creating a circular dep. I'm not sure whyvoid initneeds to exist when there'screate-void. Maybe it can be removed?Examples
Screenshots from the four generated apps. React and Vue include database-backed message forms; Svelte and Solid use Static Pages.
Validation:
CI=true vp run test: 734 test files and 14,499 tests passed; 31 tests skipped.vp run check: all 33 typecheck tasks passed.pages/style.cssmatchesstarter-ui.cssbyte-for-byte.