Repository navigation
fix(void): fail build and deploy when prerender pages fail - #586
Merged
Merged
Conversation
Fixes voidzero-dev#576 ## Summary When static prerender encounters page failures, `vp build` and managed `void deploy` only called `voidWarn` for `result.failed.length > 0`, so CI and local builds reported success while missing HTML for broken routes. They now exit non-zero. ## Changes - Add `assertNoPrerenderFailures()` in `prerender-render.ts` to throw an error listing failed paths. - Call it from the Vite prerender plugin `closeBundle` hook and after managed deploy prerender. - Leave per-path warnings during rendering unchanged. ## Testing - `vp test run packages/void/test/unit/prerender-render.test.ts packages/void/test/unit/plugin-prerender-managed.test.ts` Co-authored-by: froQ <sayhola@froq.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #576
Summary
When static prerender encounters page failures,
vp buildand managedvoid deployonly calledvoidWarnforresult.failed.length > 0, so CI and local builds reported success while missing HTML for broken routes. They now exit non-zero.Changes
assertNoPrerenderFailures()inprerender-render.tsto throw an error listing failed paths.closeBundlehook and after managed deploy prerender.Testing
vp test run packages/void/test/unit/prerender-render.test.ts packages/void/test/unit/plugin-prerender-managed.test.ts🐸