Repository navigation
test(astro): optimize drizzle-orm through void in the Astro playground - #594
Merged
Merged
Conversation
The playground listed drizzle-orm/sqlite-core in optimizeDeps.include, but drizzle-orm is Void's dependency, so Vite could not resolve the name and skipped it. The first request then found it, re-optimized and reloaded mid-request, which made the dev smoke test miss its 20 s start limit under a full parallel run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
@codex review |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://test-astro-playground-optimize-deps-void-cloud.voidzero-docs.workers.dev (commit 1d79ec4)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Astro playground's dev smoke test (
astro.test.ts > playground/astro dev) sometimes misses its 20 s start limit during a full parallel run. The server log shows why:astro.config.mjslistsdrizzle-orm/sqlite-coreso it is optimized up front, butdrizzle-ormis Void's dependency, not the playground's, so Vite can't resolve that name and skips it. This names it through Void (void > drizzle-orm/sqlite-core), the same way Void's own plugin namesvoid > email-validator.astro dev(.voidand.wranglerremoved)GET /Only the playground config changes.
Seen while working on #571.
vinext-pages devfailed the same way once in another run. I didn't capture its log, and its config has nooptimizeDeps, so this PR doesn't claim to fix that one.🤖 Generated with Claude Code