fix(transcript): record the codex session model from turn_context - #499
fix(transcript): record the codex session model from turn_context#499Yurii214 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughCodex transcript normalization now reads the session model from the first non-empty ChangesCodex model attribution
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3a7f7ae to
1d88d8b
Compare
1d88d8b to
92cb630
Compare
parse_codex_transcript only read session_meta, which carries cwd, branch and timestamps but not the model — codex puts the turn model on the turn_context record. so the normalized transcript's session model was always none for codex, while the claude parser fills it from the assistant message. read the model off turn_context (first non-empty wins) so both agents expose it.
92cb630 to
d8e954f
Compare
|
Hi @plind-junior — friendly heads-up on this one: it's fully green (tests pass on py3.11/3.12/3.13 and CodeRabbit approved the change), but it can't auto-merge because the Since posting that status / merging past it needs owner permissions, would you be able to merge this manually when you get a chance? It's a small, self-contained fix (codex transcripts drop |
parse_codex_transcriptpopulatedsession.modelfrom nowhere — it only handledsession_meta, which carries cwd, branch and timestamps but not the model. codex records the turn's model on a separateturn_contextrecord, so the normalized transcript'ssession.modelwas alwaysNonefor codex, whileparse_claude_transcriptfills it from the assistant message.this reads the model off
turn_context(first non-empty wins, since the model can change across turns), so both agents expose the session model symmetrically. no other field is touched.verified:
pytest tests/,mypy src,ruff check src testsall green. the codex transcript test now asserts the model is extracted.Summary by CodeRabbit