fix: replace yaml.FullLoader with yaml.safe_load (CVE-915) - #52
Open
Jah-yee wants to merge 1 commit into
Open
Conversation
Replace yaml.load(inputString, Loader=yaml.FullLoader) with yaml.safe_load(inputString) to prevent deserialization vulnerabilities when processing untrusted YAML diagram input. CWE-915: Improperly Controlled Modification of Dynamically-Determined Object Attributes. FullLoader permits YAML constructs that go beyond JSON-equivalent data, creating a wider attack surface.
Author
|
Thank you for maintaining wavedrompy! This PR replaces yaml.FullLoader with yaml.safe_load to address CWE-915 when processing untrusted diagram input. Happy to make any adjustments based on your feedback. |
Author
|
Friendly ping — any updates? Happy to address feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace yaml.load(inputString, Loader=yaml.FullLoader) with yaml.safe_load(inputString) in wavedrom/init.py to fix CWE-915 vulnerability when processing untrusted YAML diagram input.
Security Fix
CWE-915: Improperly Controlled Modification of Dynamically-Determined Object Attributes
Changed
Before: yamlCode = yaml.load(inputString, Loader=yaml.FullLoader)
After: yamlCode = yaml.safe_load(inputString)
Testing