Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @atadatcu on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
Every PR must be linked to a same-repo issue before Oz can review it. This PR is linked to #14234, but no linked issue is marked See the contribution guidelines for the full readiness model. Powered by Oz |
github-actions
Bot
added
the
external-contributor
![warp-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
Next step: open or find a same-repo issue describing this change, then link it to this PR by adding Closes #123 to the PR description (or using the "Development" sidebar on GitHub). A maintainer will mark the issue ready-to-implement when it is ready. Once it is marked, comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
/warp-agent-review |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #14234, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
52d9451 to
5d4dcb9
Compare
Warpified SSH (and some bash sessions) could require multiple Enter presses because Precmd was dropped before session registration and user commands were queued after the block was already marked started. Fixes warpdotdev#14234 Co-authored-by: Grok <grok@x.ai>
Inherit only session metadata after in-band commands, keep input focus on submit, and queue Enter until real Precmd so Tab and Enter both work under SSH completer load. Co-authored-by: Grok <grok@x.ai>
|
/warp-agent-review |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #14234, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
|
Hi @atadatcu — a reviewer requested changes on this PR and it hasn't had activity from you in 7 days. When you get a chance, please push updates or reply to the review so a reviewer can take another look. Without activity, this PR will be automatically closed after 14 days of inactivity. |
|
/warp-agent-review |
There was a problem hiding this comment.
Every PR must be linked to a same-repo issue before Oz can review it.
This PR is linked to #14234, but no linked issue is marked ready-to-implement yet. Only repository maintainers apply that label, so please wait for a maintainer to mark the issue. Once it is marked, push a new commit or comment /warp-agent-review to re-trigger review.
See the contribution guidelines for the full readiness model.
Powered by Oz
1 participant
Warpified SSH (and some bash sessions) could require multiple Enter presses because Precmd was dropped before session registration and user commands were queued after the block was already marked started.
Closes #14234
Description
Also found out that Tab path completions could break under the same conditions. The cause was that shell hooks and the remote completer got out of sync with block/session state. Enter was dropped or queued while UI looked active.
Fix:
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runAlso passed all tests.
Screenshots / Videos
0929.mp4
Agent Mode