Skip to content

chore(guard): sync vendored public-repo-guard to canonical - #33

Open
wave-av-release-bot[bot] wants to merge 1 commit into
mainfrom
chore/guard-canonical-sync
Open

chore(guard): sync vendored public-repo-guard to canonical#33
wave-av-release-bot[bot] wants to merge 1 commit into
mainfrom
chore/guard-canonical-sync

Conversation

@wave-av-release-bot

@wave-av-release-bot wave-av-release-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Syncs the vendored public-repo-guard trio to the canonical source in wave-foundation/scaffolder/public-repo-guard.

  • adds the internal-ip leak rule (Tailscale-CGNAT 100.64.0.0/10), lockstep with the pre-publish mirror gate
  • reconciles accumulated drift in the vendored copy

Each changed file is byte-for-byte identical to canonical (verified by git blob SHA). The repo's own Secrets + content policy gate re-scans this PR.

🤖 Generated with Claude Code


Open in Devin Review

Summary by cubic

Synced the vendored public-repo-guard with wave-foundation/scaffolder/public-repo-guard. Adds an internal IP leak rule and hardens the guard workflow by upgrading actions/checkout to v7 with no persisted credentials.

  • New Features

    • Add leak rule for internal IPs (Tailscale CGNAT 100.64.0.0/10), matching the pre-publish mirror gate.
  • Dependencies

    • Upgrade actions/checkout from v5.0.1 to v7.0.0 and set persist-credentials: false to avoid exposing the job token during the third-party scan.

Written for commit 9c500d0. Summary will update on new commits.

Review in cubic

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR author is in the excluded authors list.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

Comment on lines +45 to +53
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
with:
# Checkout defaults to persisting the job token for later steps: since v6 it
# lives in a file under $RUNNER_TEMP referenced from .git/config, no longer in
# .git/config itself. It is still a live credential in the job, and this job
# downloads a third-party binary (gitleaks, below) and runs it over the whole
# tree. Nothing here pushes -- the scan is `--no-git` over the working tree --
# so no step needs authenticated Git; drop it. (zizmor: artipacked)
persist-credentials: false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Checkout pin now inconsistent with other workflows in the repo

This workflow is bumped to actions/checkout v7.0.0 while the other workflows still pin older versions (.github/workflows/_checks.yml:23,54,114 at v4.3.1, .github/workflows/shell-lint.yml:20 and .github/workflows/governance-enforce.yml:27 at v6.0.3). Those other checkouts also do not set persist-credentials: false, so the artipacked hardening applied here is only partial across the repo. Worth aligning pins and the hardening flag repo-wide in a follow-up.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@macroscopeapp

macroscopeapp Bot commented Aug 4, 2026

Copy link
Copy Markdown

Approvability

Verdict: Needs human review

Unable to check for correctness in 9c500d0. This PR updates the checkout action and adds security hardening (persist-credentials: false). However, the changed workflow file is owned by wave-av/streaming-team, and the author (wave-av-release-bot) is not a designated owner, so the owning team should review this sync.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants