Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1009.
Accept private P-256 (
prime256v1)KeyObjectvalues alongside base64url strings for VAPID private keys. Pass prepared keys directly to the existingjwssigner, avoiding repeated decoding, ASN.1/PEM encoding and key parsing.Keep string behavior, ES256/JWT claims and expiration, both content encodings, global reset and per-request overrides unchanged. Reject public, symmetric, RSA and other-curve key objects. Includes documentation and 15 regression cases, including signature verification, payload decryption and a loopback HTTPS send.
Validation (local macOS):
Live browser tests against FCM/Mozilla and hosted CI have not been verified locally.