Skip to content

feat: add typescript types - #972

Open
43081j wants to merge 2 commits into
web-push-libs:masterfrom
43081j:jg/types
Open

43081j wants to merge 2 commits into
web-push-libs:masterfrom
43081j:jg/types

Conversation

@43081j

@43081j 43081j commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Adds the correct JSDoc so we can use typescript to generate d.ts from it.

@marco-c this is more a nice-to-have. we have good enough JSDoc to generate the types so it might be nice to do so and publish them.

if you don't think we should, though, let me know.

Comment thread src/http_ece.d.ts Resolved
Comment thread src/asn1.d.ts Resolved
@43081j

43081j commented Oct 29, 2026

Copy link
Copy Markdown
Contributor Author

Adds the correct JSDoc so we can use typescript to generate `d.ts` from
it.
@43081j

43081j commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

@marco-c i rebased onto latest master, and replaced asn1.js with asn1js.

worth noting this means we need to also bump our engines to at least what asn1js requires (^20.19.0 || >=22.12.0). pretty sure they require that as the version needed for require(esm) support.

we also need a new release of http_ece. can you help there?

@marco-c

marco-c commented Nov 11, 2026

Copy link
Copy Markdown
Member

Working on it: web-push-libs/encrypted-content-encoding#95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants