Repository navigation
Fix local configuration import - #98
Merged
Merged
Conversation
With 4ec6e9f, the import of additional, non-versioned ("local") configuration broke to an inconsistent mess: Instead of loading - `config.local.yml` - `config_development.local.yml` - `config_production.local.yml` - `config_test.local.yml` - `config_testing.local.yml` (as described in the README) it would load - `config.local.yml` - `config.local.php` - `config_development.local.php` - `config_production.local.php` - `config_test.local.php` This fixes this and loads the correct files again as described in the README. This is done in an effort to fix our logging configuration (Case 215413). This also fixes an additional older bug which caused `config_test.local.yml` to be loaded instead of `config_testing.local.yml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 4ec6e9f, the import of additional, non-versioned ("local") configuration broke to an inconsistent mess:
Instead of loading
config.local.ymlconfig_development.local.ymlconfig_production.local.ymlconfig_test.local.ymlconfig_testing.local.yml(as described in the README)
it would load
config.local.ymlconfig.local.phpconfig_development.local.phpconfig_production.local.phpconfig_test.local.phpThis fixes this and loads the correct files again as described in the README.
This is done in an effort to fix our logging configuration (Case 215413).
This also fixes an additional older bug which caused
config_test.local.ymlto be loaded instead ofconfig_testing.local.yml