Expose native HttpOnly cookie queries and fix packaged Windows startup - #51
Merged
Merged
Conversation
TIMER-err
marked this pull request as draft
August 24, 2026 06:18
TIMER-err
marked this pull request as ready for review
August 24, 2026 06:39
Author
|
@shannah Could you review this PR? |
Author
|
ok, just ignore it. |
Collaborator
|
ignore it because it's not an issue? or ignore it because you got impatient with me responding? |
Author
|
you are right, it's not a issue. i apologize if i made you feel uncomfortable. but i didnt got impatient, if you dont want to merge it, just close it. |
shannah
added a commit
that referenced
this pull request
Sep 30, 2026
Native getCookies API (from #51) with review fixes and per-platform demo
Collaborator
|
Thanks @TIMER-err, this is a great addition! Your commits have been merged into Because this PR comes from a fork, the follow-up fixes went into #61 as a separate branch, on top of your commits:
Thanks again for the contribution! Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebViewComponent.getCookies(String)returning aCompletableFuture<String>on the Swing EDTHttpOnlycookies are includedCookieheader syntax%LOCALAPPDATA%\SwingWebViewdirectory so packaged applications installed inProgram Filesstart without elevationWEBVIEW2_USER_DATA_FOLDERoverrides and fall back to the Windows temporary directory when Local AppData is unavailableValidation
mvn -DskipTests=false -Dmaven.test.skip=false testHttpOnlycookie andgetCookies()retrieved it successfully%LOCALAPPDATA%\SwingWebView, createdEBWebView, and JavaScript evaluation returned"qplayer-webview2-ok"Cross-platform build: https://github.com/TIMER-err/swingwebview/actions/runs/32698087328