Repository navigation
fix(css): migrate cssnano options to native minification - #22
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 2ec7eef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CSS codemod currently leaves
css-minimizer-webpack-pluginin place. Migrate supported cssnano default-preset options tooptimization.minimizeOptions.css: for example,discardComments: { removeAll: true }becomescomments: falsewith comment extraction disabled, andcolormin: falsebecomesshortenColors: false.Keep minimizer recognition and option translation in separate modules, using AST edits and scope resolution. Preserve the build's minimize switch, other asset types, custom minimizers, and compatible native settings. Unsupported or conflicting configurations retain their original plugin and options. The package dependency is retained for remaining uses elsewhere in the project.
Include a patch changeset for
@webpack/css-plugins-to-native-css.What kind of change does this PR introduce?
Fix: extend the CSS migration to preserve supported minifier options.
Did you add tests for your changes?
Yes, 46 fixtures covering CJS/ESM/TypeScript, option translation, existing native options, other asset types, custom minimizers, unsupported configurations, shadowed/reassigned bindings, CRLF, and idempotence.
Validation passed:
npm test— all 233 tests passed.npm run lintandnpm run type-check.Does this PR introduce a breaking change?
The new minifier migration targets webpack >= 5.112.0, including its comment extraction controls; projects using this migration must meet that requirement. Existing loader/extraction migrations retain their webpack >= 5.109.0 requirement.
Some native switches group several cssnano passes. Disabling one of those passes disables the native group, which can result in fewer optimizations.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Updated the codemod README with a before/after example, option mappings, version requirements, unsupported cases, and dependency cleanup guidance. Updated the root README and registry/workflow descriptions.
Use of AI
Codex assisted with inspecting the upstream APIs, implementing the AST migration, adding fixtures and documentation, running the validations above, and drafting this description.