Repository navigation
feat: add html-plugins-to-native-html codemod - #9
Conversation
🦋 Changeset detectedLatest commit: 91310b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
(Adding myself as a reviewer so it'll ping me when it's ready for review xD) |
|
if you need 👀 on your pr, I can help |
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/webpack/codemods.git", | ||
| "directory": "codemods/html-plugins-to-native-html", | ||
| "bugs": "https://github.com/webpack/codemods/issues" | ||
| }, |
There was a problem hiding this comment.
since it's not shallow by the codemod Registry and not going to be publish on npm registry you can remove it. it's reduce maintenance
There was a problem hiding this comment.
https://github.com/nodejs/userland-migrations/blob/main/utils/src/remove-dependencies.ts
also copy test to be sure
| npx codemod run @webpack/html-plugins-to-native-html | ||
| ``` | ||
|
|
||
| ## Example |
There was a problem hiding this comment.
use diff it's much more simpler to read and get what change
|
also general recommendation, don't use |
I guess we can give you commit access. I’ve freed up a bit of time anyway, so I’ll keep working on this PR. @avivkeller wdyt? |
Translate supported HTML minification settings, preserve existing configuration and used dependencies, and apply template changes through AST workflow steps without filesystem APIs. Add regression and workflow tests covering dry runs and idempotence.
245a8e2 to
307e44d
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
Adds the
@webpack/html-plugins-to-native-htmlcodemod, migratinghtml-webpack-plugin(plushtml-loaderand the csp/sri/favicons companion plugins) to webpack's native HTML support (experiments.html/output.html), including per-entry multi-page setups, hook-tap renames, and rewritingtemplatefiles into HTML entry points.What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes — 25 fixture cases under
codemods/html-plugins-to-native-html/tests/plus 2remove-dependenciescases.Does this PR introduce a breaking change?
No.
If relevant, what needs to be documented once your changes are merged or what have you already documented?
The codemod's README documents every mapping; the Codemod Registry entry is published from
codemod.yaml.Use of AI
This codemod was written with Claude Code (Claude Fable 5) under human direction and review: the option/hook mappings were verified against the webpack and html-webpack-plugin sources, and all fixtures, lint, and type checks pass locally.