Skip to content

feat: convert source to native ES modules with dual ESM/CJS build#5684

Open
bjohansebas wants to merge 5 commits into
nextfrom
dual-commonjs-esm
Open

feat: convert source to native ES modules with dual ESM/CJS build#5684
bjohansebas wants to merge 5 commits into
nextfrom
dual-commonjs-esm

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

Summary

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@changeset-bot

changeset-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 78b3cc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
webpack-dev-server Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.90%. Comparing base (4810909) to head (78b3cc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5684      +/-   ##
==========================================
- Coverage   88.93%   88.90%   -0.03%     
==========================================
  Files          13       13              
  Lines        5919     5922       +3     
==========================================
+ Hits         5264     5265       +1     
- Misses        655      657       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread package.json Outdated
"require": "./dist/Server.js",
"default": "./lib/Server.js"
},
"./lib/*": "./lib/*",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we should allow lib, it is more internal code

@alexander-akait alexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's resolve lib directory and we can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants