Fix/vite manifest transitive css - #128
Merged
Merged
Conversation
Rollup can fold a CSS-only entry into a shared chunk that a sibling entry only "imports" rather than owning a direct "css" key of its own (e.g. two Vite entries importing the exact same CSS module). renderProductionTags() only read the entry's own manifest "css" key, so the imported entry silently lost its stylesheet <link> tag in production builds even though the CSS file was built and present. Walk the manifest's "imports" chain recursively (with cycle/dedup guards) to collect CSS owned by any chunk the entry depends on.
9 tests: collectCss() direct/transitive/deduped/cyclic-safe collection in isolation via reflection, plus end-to-end assets() checks against a manifest fixture reproducing the shared-chunk scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.