docs(security): write down the threat model and correct two claims - #91
Conversation
Narrow the edge-cli sentence to the workflow's paths filter, stop naming an admin count and a delivery guarantee for advisory notifications, make the out-of-scope bullet compatible with in-scope token storage, add a threat model for the repository and release pipeline, and code-own SECURITY.md. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ThXwuYTEizf7foXH3biz5P
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: wego/cli/.coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: wego/cli/.coderabbit.yaml Review profile: ASSERTIVE Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 3 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughThe pull request updates security reporting guidance and threat-model scope in ChangesSecurity reporting policy
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The security guidance and ownership update have no identified merge-blocking issue. Confirm the described repository protections during normal review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
edge-clihas anon.push.pathsfilter (.github/workflows/edge-cli.yml:31-42:src/**,scripts/**,plugin/**,skills/**,package.json,bun.lock,tsconfig.json,biome.jsonc, the two composite actions, the workflow itself). The new wording is narrowed to that filter. The conclusion still holds, because a vulnerability fix lands insrc/**.## Threat model(SECURITY.md:76-108). Each boundary claim was checked:gh api repos/wego/cli→visibility: public.pull_request_target:git grep -nE "pull_request_target" -- .github/returns nothing.release-badge.yml:41watches onlyRelease (cli)(tag push,release-cli.yml:36-37) andPromote (cli)/Rollback (cli)(workflow_dispatchonly). The two fork-triggerable workflows,ci-cliandfulcio-pin-check, are not in that list.gh api repos/wego/cli/branches/main/protection→require_code_owner_reviews: true, with release paths listed in.github/CODEOWNERS.gh api repos/wego/cli/rulesets/22870024(v-tags,refs/tags/v*, creation/update/deletion). Its bypass actors are thewego-cli-releaseapp (gh api apps/wego-cli-release→ id 4905398) and thecli-release-signersteam (id 19618049)./SECURITY.mdis now owned. The self-update and credential entries (.github/CODEOWNERS:56-63) cite it as their reason for being owned, so its scope should not be narrowable without the same review.The threat model is published. Specific weaknesses we have chosen to deprioritize are deliberately left out of this public file.
Checks:
bun run lintpasses andbun test scripts/gives 407 pass, 0 fail.🤖 Generated with Claude Code
https://claude.ai/code/session_01ThXwuYTEizf7foXH3biz5P
Summary by CodeRabbit
edge-clipublishes updates and how to report security findings.