Fix the CSS file-scheme import test on Windows - #1550
Merged
Merged
Conversation
The fixture built `file://D:\...` from a backslashed temp path. Assetic splits a `scheme://` import on `/` to find its host and path before the import validator runs, so on Windows it raised "Undefined array key 1" instead of reaching the validator. The fixture now uses forward slashes, which is also the valid form for a file URL.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1549, whose
CombineAssetsTest::testCssImportFilterBlocksFileSchemeImporterrors on everywindows-latestjob:The test's fixture built the import target as
file://+ the temp file path, which on Windows isfile://D:\a\.... Before the import validator runs, Assetic'sCssImportFiltersplits ascheme://target on/to find its host and path, and a backslashed path has no/to split on.The fixture now writes the path with forward slashes, which is also the valid form of a
file://URL on Windows. It's a test-only change; the Ubuntu jobs were unaffected.Summary by CodeRabbit