fix: wrong yaml file identation syntax

[alexandreferris]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Wrong .yaml file syntax identation

Solutions

pushed as {{ - if .. but should be {{- if ..

[claude]

Review: fix: wrong yaml file identation syntax

Thanks for the fix! This is a correct and worthwhile change.

Assessment

The diff corrects two malformed Go template action delimiters in helm/githubapp/templates/statefulset.yaml: it changes {{ - if .Values.redis }} to {{- if .Values.redis }} and {{ - end }} to {{- end }}.

This is more than a cosmetic indentation fix — it was a blocking bug. The whitespace-trim marker in Go templates must be {{- with the dash immediately adjacent to the braces. With a space ({{ - if ... }}), the parser treats - if as an expression beginning with a unary-minus operator, which is a parse error. As written, helm template / helm install would have failed outright for this chart whenever it was rendered, so the entire Redis env-var block (and the statefulset) could not deploy.

Verification

• The corrected {{- if .Values.redis }} / {{- end }} now matches the style used consistently elsewhere in the same file (lines 57, 58, 69, 85, 89).
• .Values.redis exists in values.yaml (with secretName, hostKey, portKey), so the guarded block references resolve correctly.
• Scope is minimal and self-contained — exactly two lines, no behavioral change beyond fixing the syntax.

Minor suggestions (non-blocking)

• Typo in title/branch: 'identation' should be 'indentation'. Harmless, but worth noting for the commit history.
• Prevention: consider adding a helm lint / helm template step to CI so malformed template delimiters like this are caught automatically before merge. A single helm template ./helm/githubapp invocation would have surfaced this error.

No bugs, performance, security, or test-coverage concerns for a change of this nature. LGTM.