Skip to content

ci: remove unused node-version input from Japanese lint workflow - #14795

Merged
morinokami merged 1 commit into
withastro:mainfrom
morinokami:remove-unused-node-version
Oct 27, 2026
Merged

morinokami merged 1 commit into
withastro:mainfrom
morinokami:remove-unused-node-version

Conversation

@morinokami

Copy link
Copy Markdown
Member

Description (required)

While reviewing #14778, I noticed that the Japanese lint workflow passes Node 20 as a node-version input to .github/actions/install, but that action defines no inputs and pins Node to 24.18.0. The value is ignored, and every run logs Unexpected input(s) 'node-version', valid inputs are [''].

This PR removes the unused input.

References

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🙌🏽

@morinokami
morinokami merged commit a4a9bcc into withastro:main Oct 27, 2026
10 checks passed
@morinokami
morinokami deleted the remove-unused-node-version branch October 27, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants