Skip to content

build: skip electron download in the CI #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giladgd merged 1 commit into from
Nov 5, 2026
Merged

build: skip electron download in the CI #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
node-version: "22"
package-manager-cache: false
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- name: Build
run: npm run build
Expand Down Expand Up @@ -467,6 +469,8 @@ jobs:
node-version: "22"
package-manager-cache: false
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- name: Download build artifact
uses: actions/download-artifact@v8
Expand Down Expand Up @@ -533,6 +537,8 @@ jobs:
sudo apt-get install ninja-build cmake

- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci

- name: Build binary
Expand Down Expand Up @@ -578,6 +584,8 @@ jobs:
alias make=cmake

- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci

- name: Build binary
Expand Down Expand Up @@ -641,6 +649,8 @@ jobs:
- name: Update npm
run: npm install -g npm@latest
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- uses: actions/download-artifact@v8
with:
Expand Down Expand Up @@ -870,6 +880,8 @@ jobs:
node-version: "22"
package-manager-cache: false
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- uses: actions/download-artifact@v8
with:
Expand Down Expand Up @@ -951,6 +963,8 @@ jobs:
node-version: "22"
package-manager-cache: false
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- uses: actions/download-artifact@v8
with:
Expand Down Expand Up @@ -1014,6 +1028,8 @@ jobs:
# node-version: "22"
# package-manager-cache: false
# - name: Install modules
# env:
# ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
# run: npm ci
#
# - name: Pull artifact from broken release
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ jobs:
with:
node-version: "22"
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- name: ESLint
run: npx eslint
Expand All @@ -36,6 +38,8 @@ jobs:
with:
node-version: "22"
- name: Install modules
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: "1"
run: npm ci
- name: Build
run: npm run build
Expand Down
Loading