Repository navigation
docs(guides): rename the read view to reach - #596
Merged
Merged
Conversation
aicayzer
commented
Oct 23, 2026
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Review: ready to merge
Summary. Renames the read view to reach in the docs pages and the synced files, after withmarfa/marfa#2344 merged; the sync from marfa main also picks up the event log retention default changed there.
First draft: 5/5. Nothing of consequence found.
Reviewed with codex review --base origin/main. This review may contain mistakes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pages that named the read view now call it the reach, matching withmarfa/marfa#2344 (the rename of the concept, the
X-Marfa-Reachheader, thereach_changederror code and thereachchapter of the contract). The generated files follow from the same marfa change. The same pull request also carries the one-line fix to theedge.updatedrow of the event table, which now says an event also fires when one of an edge's ends moves to another item.Merge this after withmarfa/marfa#2344. Until that merges, the contract links to
conformance/spec/reach.mdpoint at a chaptermaindoes not have yet.Changes
409 reach_changedentry in Troubleshooting, the contract links in Keep a copy in sync and in Events, the key-change recovery in Sync a folder, and the Swift SDK page's example of acopyExpiredreason.openapi.json, the glossary, the error codes, the event types and fields, the settings table and the contract index, written byscripts/sync-from-marfa.shfrom the branch of #2344. The sync also brings in the glossary change that merged in marfa since the last sync.ReachChangedFrame.Testing
pnpm testpasses (39 files, 698 tests), including the content lint, the glossary check and the command check..github/scripts/sync-from-marfa.test.shpasses (615 checks).pnpm buildandpnpm types:check. The change touches no code undersrc/.Notes for reviewers
main. After #2344 merges, run the sync again from an up-to-date marfamain; it should change nothing.reach_changedas areason. The SDK gets that name when its core pin moves to a release that includes #2344; the page is right from that release.Checklist