Repository navigation
docs(catalog): document system.view and saving a list as a view - #601
Merged
Merged
Conversation
3 tasks done
aicayzer
commented
Oct 24, 2026
aicayzer
left a comment
Contributor
Author
There was a problem hiding this comment.
Reviewed with Codex at medium effort after re-syncing from marfa main (6b942076d, the merged /views door): no findings. The view guide and the system.view Catalog page agree with the contract, and openapi.json matches marfa. Docs tests: 700 passed locally.
aicayzer
marked this pull request as ready for review
October 24, 2026 02:22
aicayzer
enabled auto-merge (squash)
October 24, 2026 02:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents views, the saved lists of items that withmarfa/marfa#2359 adds as the
system.viewtype and the/viewsoperations. The Catalog gets asystem.viewpage, the list guide says how to save a list as a view, and the API reference lists the Views operations.Merge this after withmarfa/marfa#2359. The sync here ran against that pull request's branch, so run the sync again from marfa
mainonce it merges and push the result to this branch before merging.Changes
catalog/(system)/view: a new page with the type's title, description and identifier, and its generated file. It links to the guide and toitems/system-types, the rule that keeps the item operations from writing a view.guides/list-filter-search: a "Save a list as a view" section, before "When a query is refused". CLI, HTTP and TypeScript tabs create a board view ofcore.task, grouped byproperties.priority, of tasks not completed. It says how to change, delete and read a view, which permissions each needs, how a refused setting is named indetails.errors[0].path, and links theviewschapter of the contract.api-reference: a Views row after Folders.src/lib/docs-map.test.ts: the system types now include View.openapi.json, the glossary, the catalog (the newsystem.view.md, andcore.fileandcore.mediafrom feat(types): core.file.image and core.media declare a thumbnail marfa#2355, already on marfamain), the command tree and the contract index.Testing
pnpm test: 39 files, 700 tests passed. The first run failed on backticks in the new page's description and on the system types listed in the docs map; both are fixed.pnpm build,pnpm build:statusand thenpnpm types:checkpass.201with asystem.viewitem. The guide's CLI commands match the command tree (command-check.test.ts); the binary was run for create, change, get and delete, but not with the guide's exact arguments.Notes for reviewers
conformance/spec/views.md,openapi.jsonandpackages/server/src/routes/views.tson feat(server): add system.view and the /views door marfa#2359.Checklist