Repository navigation
Conversation
3 tasks done
…ly after a completed move
3 tasks done
Contributor
Author
|
Replaced by #633, which carries this change merged with the other Swift SDK 0.0.32 pull requests into one page. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Swift SDK page follows Marfa 0.0.35 and the matching marfa-swift release: a view holds a sort and a grouping and no layouts, an edge type has a reverse label, and the direct client can move a type. Merge it after the Swift SDK release. Pairs with withmarfa/marfa-swift#373.
Changes
settings.sortandsettings.group, how to remove each, hidden groups, andlist(inView:limit:offset:)andgroups(inView:timeZone:)without a layout argument.EdgeTypehaslabelandreverseLabel, and that without a registered reverse label the two are equal.Client, reading the result before deleting the old type, and thetype_move_blockedandtype_in_userefusals with theirdetails.Testing
pnpm exec vitest run src/lib/content-lint.test.tspasses.Notes for reviewers
swift-sdk.mdxand merge after the Swift SDK release. docs(swift-sdk): document the client for server-only calls #627 adds a "Call the server directly" section; this branch is based onmain, so Move the items of a type stands alone, introducesClientin its own words, and sits before Folders on a Mac. Whoever merges second resolves the conflict, and may fold the move section under docs(swift-sdk): document the client for server-only calls #627's new section.Checklist