Repository navigation
docs(build): say that search finds a file by its extracted text - #667
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search finds a file by the text Marfa extracts from it. The docs did not say so. This adds that to the search guide, the files guide and the Items catalog page. The matching contract statements are in the marfa pull request linked below.
Changes
build/handle-files: a new "Find a file by its text" section: when the text is available, what a device needs, and the settings that switch it off.build/list-filter-search: the Search section says a file'sextracted_textis searched, and when.catalog/items: "Searched fields" namesextracted_textand says a file type cannot setsearchabletofalseon it.Testing
pnpm testpasses (709 tests), including the content lint and the command check formarfa search --type core.file. The page was not built or viewed in a browser.Notes for reviewers
search-and-filters/search-file-text,device/index-file-text). The Items page does not link the statement yet, because the link check reads the synced contract; the sync pull request after the marfa one merges can add it.Checklist
STYLE.md.