Repository navigation
Conversation
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
The Swift SDK page gains a section, Draw a type's icon. It covers
ItemType.icon, theMarfaIconsproduct (TypeIcon,Image(typeIcon:)), and the client'sset(icon:forType:)andclearIcon(ofType:), with the permission they need and how a bad name is refused. Two rows join the client's call table.Order of merging
This pull request is stacked on #673, which adds the Display hints section and the type icon operations the new section links to. Merge #673 first; GitHub then retargets this pull request to
main. It also describes theMarfaIconsproduct from withmarfa/marfa-swift#382, so it stays a draft until that pull request is released.Checked
pnpm testpasses, including the content lint and link checks.