Repository navigation
test: prune styling, layout and wall-clock tests - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prunes tests that check styling, layout, exact wording or wall-clock time, and makes the editor tests independent of WebKit's animation frames. Every test that guards a person's text or data, the Marfa mapping, link resolution and the
Liveplan is unchanged.What was removed or changed
SoftSelectionTests(2 tests)WebViewContainerTestsLibraryPerformanceTestsInterfaceStyleTests.semanticFontsScaleWithoutChangingTheirTraitsItemTableLayoutTests.theRingFollowsTheToneSidebarTests.theFootsDotIsOrange...SyncStatusTests.countsAgreeWithTheirNounsSyncWordingTests(exact paragraphs)EditorTests.nativeFindGeometryFollowsViewportAndAppearanceChangesEditorTests+Headermargin loopchangingItemsAfterScrollingStartsAtTheTopAndStaysThereMarfaSourceOfflineTests.aWriteIsQueuedAtOnceWhileTheServerHangs10.255.255.1), which answers "connection refused" on some networks, so it failed every time here. Replaced byaWriteIsQueuedAtOnceWhileARefreshIsHeld, which holds a fake refresh in flight, submits a write, and checks it is shown and queued before the refresh is released. It uses no socket and no real address.DownloadedFilesTestsdeadline loopeventuallyAsking.every pin is one height...the header and the text share one column...style.css.vi.waitFor.Counts
@TestdeclarationsThe fixed sleeps left in the unit tests are "did not happen" checks with a comment saying so, as
AGENTS.mdallows.Tested
Unitplan throughheavy-run: all 978 cases pass.UIplan (takes over the screen; the UI tests are unchanged) and theLiveplan.Issues
Closes #144.
Closes #64. It does not reproduce. Both tests (
aCopyExpiredByAMoveKeepsEveryQueuedWriteAndTheViewandaConflictedCopyIsShownBesideItsOriginal) passed 20 of 20 in isolation and in the full Unit plan, on the current Swift SDK (0.0.37). The issue was filed against 0.0.8, 29 releases ago, so the cause was fixed in the package, not in this repository. No test was changed for it.