Repository navigation
fix(app): keep the sample-library preview out of release builds - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Xcode Cloud builds since v0.0.21 failed. After #161 fixed the build script,
v0.0.24-rc1still failed, and archiving that tag locally reproduced it:ItemRelationships.swifthas a#Previewthat usesSampleLibrary, which exists only in Debug builds, so a Release archive does not compile (introduced in #130).The preview is now inside
#if DEBUG, as the other previews that useSampleLibraryare. The hosted checks also build the Release configuration, so a Debug-only symbol used in shipping code fails a pull request instead of a tag.Checks
A local Release build of this branch succeeds (it failed before). Review depth: checks only (a preview guard and a CI step, no behaviour).