Repository navigation
chore(editor): update inkkit to 0.3.0 - #164
Merged
Merged
Conversation
Contributor
Author
Review: checks only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the note editor's Inkkit to 0.3.0. People notice three things: typing at the start of a continued line, and pasting comments into lists, now work correctly, and table corners are rounded by 4px.
Changes
@aicayzer/inkkitis pinned to0.3.0ineditor/package.jsonandeditor/pnpm-lock.yaml.MAPP/Editor/Page/editor.htmlis rebuilt withpnpm build.--inkkit-table-radius: 0pxwould restore square ones), and the new optional tokens--inkkit-checkbox-border-colorand--inkkit-drop-indicator-colorneed no action.Testing
editor/:pnpm test(68 tests in 3 files, includinglinks.test.ts, which confirms theredrawWikiLinksworkaround still works),pnpm typecheckandpnpm format:checkall pass.pnpm buildtwice gives a byte-identicaleditor.html, so the CI rebuild check should match.EditorTestsandEditorLinkTests(the built page in real WebKit) built but then sat idle in the test host and was stopped. CI then ran the fullUnitplan, which includes them, and it passed.Unitplan and the UI tests; CI builds the UI tests but does not run them.Notes for reviewers
Checks only, following the previous bump (#145). No reviewer is needed.
Checklist