Repository navigation
feat(inspector): add and remove an item's tags - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a person
You can now add and remove an item's tags in MAPP. Before, tags were read-only.
What I chose
favoritetag stays with the Favorite command: it is not listed in the tag editor, cannot be removed there, and is refused as typed text. Theconflicted-copytag is treated the same way..or.., and an item can hold at most 100. The refusal appears under the field and the typed text stays.Tested
The Unit plan passes, including new tests for add, remove, duplicate, invalid and reserved tags, a full item, an item in the bin, suggestions, queued writes with undo and redo, and a refused write.
Not tested: the Live plan (no instance was given), so offline queueing across a restart rests on the existing queue and is not exercised here. The UI plan was not run. The inspector controls were looked at only briefly in the sample library; adding a tag with Return from the field was not exercised in the running app.