Repository navigation
feat(app): add a This Marfa page for the server's own settings - #168
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a This Marfa page to Settings, so a person can see and change the connected Marfa server's own settings without its web console: its name, how long deleted items stay, and how long it keeps item versions. It is a page of its own rather than part of Library, because these settings belong to the server and not to this Mac's copy, and they have their own draft, save and failure states.
Changes
PATCH /configwith only the changed fields; Revert drops the draft. The page then shows what the server answered.config.managegets an unavailable page with an Open in Browser button.MarfaServerConfigcalls the Swift SDK client behind a smallInstanceConfigSourceseam, injected through the host like Version History.Testing
demotest instance: reads the settings, renames the server, checks nothing else changed, and puts the name back. It passed with the admin key; the MAPP key lacksconfig.manageand got the 403, which showed the unavailable path against a real server. No retention was changed on any live instance.Notes for reviewers
MarfaHost,Librariesand the String Catalog, so whichever merges second may need a rebase.Checklist