Repository navigation
feat(app): cap long link lists and mark links to deleted items - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a person
What I chose
Browser.reveal(palette, table parent link, page links) had sent a deleted item to All Items, which does not list it; it now goes to Recently Deleted as well.Tested
Unit plan, run once locally: all pass. New
LinkListTestscover groups of 0, 1, 20, 21 and 500 (rows, hidden count), expanding once and twice, state per item and group, a binned link and its recovery, a missing link, adding and removing links live, and where a deleted item opens.Not seen
No window was opened, so the look of the button and label, hover fill, and spacing are unchecked on screen. Two String Catalog keys were appended by hand ("Deleted", "Show %lld More").