Skip to content

chore(editor): update Inkkit to 0.3.1 - #174

Merged
aicayzer merged 8 commits into
mainfrom
chore/inkkit-0.3.1
Oct 26, 2026
Merged

aicayzer merged 8 commits into
mainfrom
chore/inkkit-0.3.1

Conversation

@aicayzer

Copy link
Copy Markdown
Contributor

What changes for a person

  • Typing at the end of a link no longer grows the link; the new text stays outside it, and formatting around a link is kept.
  • Lists, quotes, links, entities, lone carriage returns and comments keep their authored source more closely when edited.
  • Identical images in one paste insert once. This applies to Inkkit's own paste path; MAPP's own image paste is unchanged.
  • Files attached in quick add are now placed with Inkkit's appendImages. Selection, scroll and focus stay put, and it is one undo step.
  • Selected text uses explicit translucent colors in light and dark, and a different color when the window is inactive.
  • A link to a note that does not exist is now drawn in Inkkit's accent color with a dashed underline, instead of MAPP's muted grey.

What was done

  • Updated @aicayzer/inkkit to 0.3.1 and rebuilt MAPP/Editor/Page/editor.html.
  • raw is now required on FileReference and WikiLinkReference. Nothing in MAPP builds these, so no fixture needed changing.
  • slash-command-failed is covered by a new test: when the app fails to answer Link to Note, the page reports an error and the line stays as typed. Neither the page nor the app switches over error codes, so no new case was needed.
  • Replaced redrawWikiLinks, which sent an internal DOM event, with refreshReferences, naming only the notes whose answer changed. It changes no text, so it works in a read-only note and while composing. links.test.ts keeps its intent and now also covers both of those.
  • Replaced the source-level appendedImages workaround with appendImages. It answers false in source editing, and the app keeps the files waiting and sends them again. A note that ends in an unclosed code fence is refused by Inkkit without changing anything; the app then tells the person the files are attached but not in the text.
  • Removed the page's own .inkkit-wiki-link and selection rules, and set --inkkit-selection-background and --inkkit-inactive-selection-background. Updated both nested AGENTS.md files.

Choices

  • For an open code fence the person is told, not the fence closed, so the note's text is never changed.
  • MAPP's muted missing-link color is dropped in favor of Inkkit's styling.
  • No corpus fixture changed: the existing corpus still round-trips every byte.

Tested

  • Editor page: 72 tests, typecheck and format check pass; the rebuilt page is byte-stable.
  • Swift: the Unit plan passes locally (937 tests, none failing), including a new test for the open-fence case.

Not tested

  • Selection and link colors were not checked by eye, because that needs the screen. The UI tests were left to CI.

@aicayzer
aicayzer merged commit 7b880a5 into main Oct 26, 2026
4 checks passed
@aicayzer
aicayzer deleted the chore/inkkit-0.3.1 branch October 26, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant