Repository navigation
chore(editor): update Inkkit to 0.3.1 - #174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a person
appendImages. Selection, scroll and focus stay put, and it is one undo step.What was done
@aicayzer/inkkitto 0.3.1 and rebuiltMAPP/Editor/Page/editor.html.rawis now required onFileReferenceandWikiLinkReference. Nothing in MAPP builds these, so no fixture needed changing.slash-command-failedis covered by a new test: when the app fails to answer Link to Note, the page reports an error and the line stays as typed. Neither the page nor the app switches over error codes, so no new case was needed.redrawWikiLinks, which sent an internal DOM event, withrefreshReferences, naming only the notes whose answer changed. It changes no text, so it works in a read-only note and while composing.links.test.tskeeps its intent and now also covers both of those.appendedImagesworkaround withappendImages. It answers false in source editing, and the app keeps the files waiting and sends them again. A note that ends in an unclosed code fence is refused by Inkkit without changing anything; the app then tells the person the files are attached but not in the text..inkkit-wiki-linkand selection rules, and set--inkkit-selection-backgroundand--inkkit-inactive-selection-background. Updated both nested AGENTS.md files.Choices
Tested
Not tested