fix(docker): download model checkpoints from HuggingFace during build#21
Merged
Conversation
Replace COPY models/checkpoints/ with curl downloads so the Docker image is self-contained and works out-of-the-box without pre-downloaded models. Also remove the docker-compose volume mount that was shadowing the baked-in checkpoints when the local directory was absent or empty. Fixes #16 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…error huggingface_hub uses match statements (Python 3.10+). With python_version set to 3.9 in mypy config, following imports into that package caused a syntax error that blocked all type checking. Skip it via overrides since we don't need to type-check third-party code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COPY models/checkpoints/withcurldownloads fromhttps://huggingface.co/withoutbg/focus/resolve/main/for all 4 ONNX model files in both Dockerfilescurlto theapt-get installstep inapps/web/backend/Dockerfile(productionDockerfilealready had it)../../models/checkpoints:/app/checkpoints:rovolume mount fromdocker-compose.yml, which was shadowing the baked-in models whenever the local directory was absent or emptyRoot cause (fixes #16)
COPY models/checkpoints/ ./checkpoints/silently copied nothing since the directory isn't in the repo. TheWITHOUTBG_*_MODEL_PATHenv vars were set pointing to/app/checkpoints/, but the files didn't exist — triggeringModelNotFoundErrorimmediately on startup.Test plan
docker compose -f apps/web/docker-compose.yml buildcompletes without errorsdocker compose -f apps/web/docker-compose.yml upstarts successfully and/api/healthreturnsmodels_loaded: truedocker build -f apps/web/Dockerfile .🤖 Generated with Claude Code