Update to IDF 5.5.4 - #5769
Conversation
WalkthroughThe ESP32 IDF V5 environment now uses a newer Tasmota platform with Arduino Core 3.3.8 and IDF 5.5.4. Compatibility guards were updated for ChangesESP32 IDF V5 compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
platformio.ini (1)
322-323: 🩺 Stability & Availability | 🔵 TrivialRun hardware smoke tests for the V5 platform matrix.
This platform is inherited by all ESP32 V5 environments. Build success does not verify boot, networking, LED output, DMX, Ethernet, PSRAM, or partition behavior on hardware. Test representative board families before release.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@platformio.ini` around lines 322 - 323, Run hardware smoke tests for representative ESP32 V5 board families using the updated platform configuration, covering boot, networking, LED output, DMX, Ethernet, PSRAM, and partition behavior before release.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@platformio.ini`:
- Around line 322-323: Run hardware smoke tests for representative ESP32 V5
board families using the updated platform configuration, covering boot,
networking, LED output, DMX, Ethernet, PSRAM, and partition behavior before
release.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8ea93794-2e3a-4f42-ae60-7553a6d58797
📒 Files selected for processing (3)
platformio.iniwled00/mbedtls_sha1_shim.cppwled00/src/dependencies/time/TimeLib.h
DedeHai
left a comment
There was a problem hiding this comment.
tested on ESP32 classic, works.
Not tested with hardware yet, but this gets the build to pass
Summary by CodeRabbit